Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): useCssVars work with static vnode #3847

Merged
merged 3 commits into from
Jul 14, 2021
Merged

fix(runtime-dom): useCssVars work with static vnode #3847

merged 3 commits into from
Jul 14, 2021

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented May 29, 2021 •
edited
Loading

close #3841

@edison1105
fix(runtime-dom): useCssVars work with createStaticVNode
b8d329d 
chore: improve code

chore: improve code
@edison1105 edison1105 mentioned this pull request Jun 9, 2021
Closed
yyx990803
yyx990803 reviewed Jul 14, 2021
View reviewed changes
packages/runtime-dom/src/helpers/useCssVars.ts Outdated
style.setProperty(`--${key}`, vars[key])
}

for (var i = 0; i < el.children.length; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep recursion here is unnecessary - CSS vars only need to be set on root level elements.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@yyx990803 yyx990803 merged commit 6a0c7cd into vuejs:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

@AkiyamaKunka AkiyamaKunka AkiyamaKunka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createStaticVNode not contains style variables
3 participants
@edison1105 @yyx990803 @AkiyamaKunka