Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useCssVars): work with Transition + v-if #3922

Closed
wants to merge 3 commits into from
Closed

feat(useCssVars): work with Transition + v-if #3922

wants to merge 3 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jun 9, 2021 •
edited
Loading

close #3894

@edison1105 edison1105 marked this pull request as ready for review June 9, 2021 12:38
@edison1105 edison1105 changed the title fix(useCssVars): work with Transition feat(useCssVars): work with Transition Jun 9, 2021
@edison1105 edison1105 changed the title feat(useCssVars): work with Transition feat(useCssVars): work with Transition + v-if Jun 10, 2021
@edison1105
fix(useCssVars): work with Transition
7e3ed9d 
fix(useCssVars): improve code

chore: improve code

fix(useCssVars): improve code
@edison1105
test: update case
ad37e82
@yyx990803
Copy link
Member

See 6ed23f6 - the bug affects more than just <transition>: it occurs when:

  • a child component is used at root level
  • the child component contains slot content that may change
  • the slot content change depends on state that isn't used by the parent (so parent onUpdated doesn't trigger when the child updates)

Using MutationObserver covers all possible cases.

@yyx990803 yyx990803 closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style-vars-2 v-bind feature issue when using transition and v-if
2 participants
@edison1105 @yyx990803