-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errorHandler not used when hydrated, due to null instance #4479
Labels
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
3.2.6
Reproduction link
github.com
Steps to reproduce
Reproduction is a copy of https://github.com/vitejs/vite/tree/main/packages/playground/ssr-vue with additon of errorHandler to main.js, and button to Home.vue.
npm run dev
Then click the Throw error button on home page.What is expected?
The custom errorHandler gets called. Which logs 'no error here'
What is actually happening?
The error is logged to console.
Trying to set up Sentry.
Related to #1336
In
callWithErrorHandling
,instance
is null.Add breakpoint to
createInvoker
. Look back in the stack tohydrateElement
. InhydrateElement
,parentComponent
is set, but not passed topatchProp
The text was updated successfully, but these errors were encountered: