Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler-sfc] getImportsExpressionExp misuses the import cache with "hoisted" urls #4581

Closed
hl037 opened this issue Sep 14, 2021 · 0 comments
Closed

[compiler-sfc] getImportsExpressionExp misuses the import cache with "hoisted" urls #4581

hl037 opened this issue Sep 14, 2021 · 0 comments

Comments

@hl037
Copy link

hl037 commented Sep 14, 2021

Version

3.2.11

Reproduction link

github.com

Steps to reproduce

yarn install
yarn serve

Open the page then the devtool

What is expected?

The image should be present twice. The <use> tags should both have href="[...].svg#logo"

What is actually happening?

The image is present only once. The second <use> tag has href="[...].svg", missing the #logo

I'm making a PR to fix it.
@hl037 hl037 mentioned this issue Sep 14, 2021
Closed
hl037 added a commit to hl037/vue-next that referenced this issue Sep 14, 2021
@hl037
fix(compiler-sfc): vuejs#4581 getImportsExpressionExp with hash
a53dff4 
Subsequent calls with an url already in the import cache
and with a hash returns the correct expression including each time the
hash if one.
@hl037 hl037 mentioned this issue Sep 14, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-sfc): #4581 getImportsExpressionExp with hash hl037/vue-next
1 participant
@hl037