-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR/Hydration: Re-Render due to hydration mismatch creates inconsistent DOM - textContent updated correctly, class attr isn't. #5063
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
scope: ssr
Comments
loyep
changed the title
use computed in a SSR project attributes and nodes is different
Use Dec 6, 2021
computed
in a SSR
project attributes and nodes is different
Seems we have a bug here when bailing out of hydration because of a mismatch - the text content was updated, but the class attribute wasn't. |
LinusBorg
added
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
🐞 bug
Something isn't working
scope: ssr
labels
Dec 6, 2021
@loyep Even though yes, this is a bug - your usage of a computed here is wrong, too. Looking at the console, you can see that it causes a hydration mismatch. |
LinusBorg
removed
the
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
label
Dec 6, 2021
LinusBorg
changed the title
Use
SSR/Hydration: Re-Render due to hydration mismatch creates inconsistent DOM - textContent updated correctly, class attr isn't.
Dec 6, 2021
computed
in a SSR
project attributes and nodes is different
Yes, I know. Only in this way can we reproduce this problem quickly. |
Not only class, but also style attributes |
yyx990803
added
the
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
label
May 19, 2022
yyx990803
added a commit
that referenced
this issue
May 19, 2022
- Include the actual element in the warning message - Also warn class/style/attribute mismatches Note: class/style/attribute mismatches are check-only and will not be rectified. close #5063
wmfgerrit
pushed a commit
to wikimedia/wikibase-termbox
that referenced
this issue
Oct 18, 2022
Currently broken in Vue, due to vuejs/core#5063 Bug: T318137 Change-Id: I8a12a78bf62cccf4e9d900e09d9b49f6f124f893
yyx990803
added a commit
that referenced
this issue
Dec 8, 2023
- Include the actual element in the warning message - Also warn class/style/attribute mismatches Note: class/style/attribute mismatches are check-only and will not be rectified. close #5063
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
scope: ssr
Version
3.2.23
Reproduction link
github.com
Steps to reproduce
What is expected?
Class and text values are the same.
What is actually happening?
The text was updated successfully, but these errors were encountered: