Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition group with multiple classes as move-class not working #678

Closed
jonaskuske opened this issue Jan 30, 2020 · 0 comments · Fixed by #679
Closed

Transition group with multiple classes as move-class not working #678

jonaskuske opened this issue Jan 30, 2020 · 0 comments · Fixed by #679

Comments

@jonaskuske
Copy link
Contributor

Version

3.0.0-alpha.4

Reproduction link

https://codepen.io/21stCenturyJonas/pen/xxboELY?editors=1011

Steps to reproduce

  1. Set the move-class prop on <transitition-group> to multiple classes, separated by spaces:

<transition-group move-class="transition-transform duration-300 ease-in-out">

  1. Start a transitition by changing the order

What is expected?

The classes should be applied.

What is actually happening?

DOMExecption, as tokens passed to classList.add() mustn't contain spaces.


This is the same issue as #638 – but the fix there only handles multiple enter and leave classes, not move classes that are added as part of hasCSSTransform() in TransitionGroup.ts.

I'll provide a PR shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant