Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using event modifiers on a component it will always update unnecessarily (performance issue) #8882

Closed
basvanmeurs opened this issue Aug 1, 2023 · 0 comments
Closed

When using event modifiers on a component it will always update unnecessarily (performance issue) #8882

basvanmeurs opened this issue Aug 1, 2023 · 0 comments
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. has PR A pull request has already been submitted to solve the issue

Comments

@basvanmeurs
Copy link
Contributor

Vue version

3.3.4

Link to minimal reproduction

https://play.vuejs.org/#eNp9kk1P4zAQhv/KrC9JRTfZFTc2rRYQEnAAxIe4+FIl0xBwbMsfoSjKf2fstAEk6CXKzPs6eWb89uxY66zzyI5YYUvTaAcWnddLLptWK+OgB4NrGGBtVAsJWZNJOlWt3vazPBThS8k/LkslrYPW1rAIp9PkHIVQ8KiMqH4lMy7XXpauURK8TnEGPZcAeQ5XSumMy4HLIh9piIMKh60WK4dUARRPf5d9H78+DEVOVew2UnsH3e9WVSgWnJHO2ShFzv8v+FapV5l5TarXJBYRmjxFPv2BzZmzxL9u6uzZKkmLiXScleRtBJprHcgtZ0cjd9BWNN7rZew543G+65dPWL5803+2m9Dj7MagRdMhZ5PmVqZGN8pnd1e4ofdJpOm8IPce8RatEj4wjrYTLyvC/uSLtBfxDhtZ39uzjUNpd0MF0OAcop8zutOwpp9G/8A9zA7jObpA2uIuD/uSpeSDrmjr1fybkI0h8tFgt0H6Q9mZDqXpDBZLCD4lMBOqTrfurFsJjwcHM7LvS1LVdBSC8PyageEdl5EJeg==

Steps to reproduce

  1. Open the web developer console
  2. Focus on the input field
  3. Press keys

What is expected?

No console logs should be added as the Comp should not be updated.

What is actually happening?

Console.log messages are visible because on each keypress the Comp is updated.

System Info

No response

Any additional comments?

When @keydown is used rather than @keydown.up the Comp is not updated. It seems to be caused by using modifiers.
@edison1105 edison1105 added 🐞 bug Something isn't working 🔩 p2-edge-case 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed 🐞 bug Something isn't working 🔩 p2-edge-case labels Aug 1, 2023
@edison1105 edison1105 mentioned this issue Aug 2, 2023
Closed
@sxzz sxzz added the has PR A pull request has already been submitted to solve the issue label Aug 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. has PR A pull request has already been submitted to solve the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-core): cache v-on handler with modifiers edison1105/vuejs-core
3 participants
@basvanmeurs @edison1105 @sxzz