Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): cache v-on handler with modifiers #8896

Closed
wants to merge 6 commits into from
Closed

fix(compiler-core): cache v-on handler with modifiers #8896

wants to merge 6 commits into from

Conversation

edison1105
Copy link
Member

close #8882

@edison1105 edison1105 changed the title fix(v-on): cache handlers with modifier fix(v-on): cache handler with modifiers Aug 2, 2023
@sxzz sxzz changed the title fix(v-on): cache handler with modifiers fix(compiler-core): cache v-on handler with modifiers Aug 12, 2023
@sxzz
Copy link
Member

sxzz commented Aug 12, 2023

Seems like this PR didn't fix anything.
https://deploy-preview-8896--vue-sfc-playground.netlify.app/#eNp9kk1P4zAQhv/KrC9JRTfZFTc2rRYQEnAAxIe4+FIl0xBwbMsfoSjKf2fstAEk6CXKzPs6eWb89uxY66zzyI5YYUvTaAcWnddLLptWK+OgB4NrGGBtVAsJWZNJOlWt3vazPBThS8k/LkslrYPW1rAIp9PkHIVQ8KiMqH4lMy7XXpauURK8TnEGPZcAeQ5XSumMy4HLIh9piIMKh60WK4dUARRPf5d9H78+DEVOVew2UnsH3e9WVSgWnJHO2ShFzv8v+FapV5l5TarXJBYRmjxFPv2BzZmzxL9u6uzZKkmLiXScleRtBJprHcgtZ0cjd9BWNN7rZew543G+65dPWL5803+2m9Dj7MagRdMhZ5PmVqZGN8pnd1e4ofdJpOm8IPce8RatEj4wjrYTLyvC/uSLtBfxDhtZ39uzjUNpd0MF0OAcop8zutOwpp9G/8A9zA7jObpA2uIuD/uSpeSDrmjr1fybkI0h8tFgt0H6Q9mZDqXpDBZLCD4lMBOqTrfurFsJjwcHM7LvS1LVdBSC8PyageEdl5EJeg==

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 12, 2023
@edison1105
Copy link
Member Author

Seems like this PR didn't fix anything. deploy-preview-8896--vue-sfc-playground.netlify.app/#eNp9kk1P4zAQhv/KrC9JRTfZFTc2rRYQEnAAxIe4+FIl0xBwbMsfoSjKf2fstAEk6CXKzPs6eWb89uxY66zzyI5YYUvTaAcWnddLLptWK+OgB4NrGGBtVAsJWZNJOlWt3vazPBThS8k/LkslrYPW1rAIp9PkHIVQ8KiMqH4lMy7XXpauURK8TnEGPZcAeQ5XSumMy4HLIh9piIMKh60WK4dUARRPf5d9H78+DEVOVew2UnsH3e9WVSgWnJHO2ShFzv8v+FapV5l5TarXJBYRmjxFPv2BzZmzxL9u6uzZKkmLiXScleRtBJprHcgtZ0cjd9BWNN7rZew543G+65dPWL5803+2m9Dj7MagRdMhZ5PmVqZGN8pnd1e4ofdJpOm8IPce8RatEj4wjrYTLyvC/uSLtBfxDhtZ39uzjUNpd0MF0OAcop8zutOwpp9G/8A9zA7jObpA2uIuD/uSpeSDrmjr1fybkI0h8tFgt0H6Q9mZDqXpDBZLCD4lMBOqTrfurFsJjwcHM7LvS1LVdBSC8PyageEdl5EJeg==

Ah, I forgot to test the usage passed to the component

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.7 kB 29.5 kB
vue.global.prod.js 132 kB 49.4 kB 44.4 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 50.7 kB 20 kB 18.2 kB
defineCustomElement 50.3 kB 19.7 kB 18 kB
overall 61.3 kB 23.7 kB 21.6 kB

@yyx990803
Copy link
Member

I think it's more straightforward to cache directly on the wrapped function: da4a4fb

@yyx990803 yyx990803 closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using event modifiers on a component it will always update unnecessarily (performance issue)
3 participants
@edison1105 @sxzz @yyx990803