Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR Rendering of select input with slot is breaking #9440

Closed
matrei opened this issue Oct 20, 2023 · 1 comment · Fixed by #9442
Closed

SSR Rendering of select input with slot is breaking #9440

matrei opened this issue Oct 20, 2023 · 1 comment · Fixed by #9442
Labels
🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. 🐞 bug Something isn't working

Comments

@matrei
Copy link

matrei commented Oct 20, 2023

Vue version

3.3.5

Link to minimal reproduction

https://play.vuejs.org/#eNqNVMlu2zAQ/RVCF6eAJSINejGUIG2RQwp0QV30UvWgSGObqUQS5EhxIejfOyQlm3GTIPBFnDfLm+V5SN5rnfUdJKskt5URGpkF7PRVIUWrlUE2MAMbNrKNUS1bkOviAK2hgQpvpe5wgjMe2Vxecna/SknrMjsM6q8ahZLs0mU+W0yv88Wb2U95iyWHX0d0yebvt4vfIWvOA2UiSw+EVjclAr0Yy3fnV8NwWnEcc06AdwhQKjz7Pm1VDc1lkTyOKBLWlHceCI0xq1rAnZDbIvF5KFOgSzk2ypDj9BRy7oOS9CnCHg8gxeY8fAYyPGZDppwfukmWSRh32pY6u7dK0q4GF1VMABVYMW9xNhq6exfJDlHbFedVLSmMuhO9ySQgl7rl1+TGTSdRtJDWqr2+yC6yd7wWFmNzBrZN74x6sGAoSZEsozJE2vRgUgOyBgPmtWVPwuLSJ9B/5V31sZAjDQUtHctGbE9GUqlWiwZM2N/j0ZRNox4+eRuaDg69VDuo/jxhv7f70NM3A55Z1D+WZgsY4Jv1F9puBNIxdc20hmfA72BV04VjcG4fOlkT7cjPs731G6Zz+2Fv9gjSzk05on4a3t/v4+MLrR/p0rSjKZ7I9Ym/gVmUXiA/y6YD0mUNGyHhszOdDfhXw4qt0RDNkUT8sjBr0c/CCUcfie9Y46Au59Yo5HPMpJRJNiFZrJbxH7jOplw=

Steps to reproduce

  1. Click the SelectInput.vue tab.
  2. Click the SSR tab.
  3. See compile error

What is expected?

The component should compile

What is actually happening?

A compile error

System Info

No response

Any additional comments?

This has been compiling fine earlier.
@LinusBorg LinusBorg added 🐞 bug Something isn't working 🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. labels Oct 20, 2023
@LinusBorg
Copy link
Member

LinusBorg commented Oct 20, 2023 •
edited
Loading

@edison1105 I think this commit broke selects with v-for in a slot: 201c46d

First assumption is that it's not unwrapping the v-for fragment? The playground works if we remove the v-for and pass in a hardcoded list of nodes.

@edison1105 edison1105 mentioned this issue Oct 20, 2023
Merged
yyx990803 pushed a commit that referenced this issue Oct 20, 2023
@edison1105
fix(compiler-ssr): fix ssr compile error for select with non-option c…
cdb2e72 
…hildren (#9442)

fix #9440
yyx990803 pushed a commit that referenced this issue Oct 21, 2023
@edison1105 @yyx990803
fix(compiler-ssr): fix ssr compile error for select with non-option c…
9dbff73 
…hildren (#9442)

fix #9440
lumozx pushed a commit to lumozx/core that referenced this issue Oct 21, 2023
@edison1105 @lumozx
fix(compiler-ssr): fix ssr compile error for select with non-option c…
fcf7e50 
…hildren (vuejs#9442)

fix vuejs#9440
sxzz pushed a commit that referenced this issue Oct 23, 2023
@edison1105 @sxzz
fix(compiler-ssr): fix ssr compile error for select with non-option c…
4fbd6e2 
…hildren (#9442)

fix #9440
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ssr): render initial selected properly edison1105/vuejs-core
2 participants
@LinusBorg @matrei