Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #10192 When passing a Vnode to the 'is' prop of a <component>, the page does not refresh upon changes in the Vnode #10193

Closed
wants to merge 1 commit into from

Conversation

zimoua
Copy link

@zimoua zimoua commented Jan 23, 2024

This is a proposal I submitted for bug #10192.

minimal reproduction

The VNode generated by the slot possesses a pathFlag value of 1(TEXT), which, when subjected to a bitwise OR operation with PatchFlags.BAIL (-2), yields PatchFlags.HOISTED (-1). As a consequence, this results in the diff process omitting the update of the VDom. I am uncertain as to the rationale behind employing a bitwise OR operation in this context and am eager to learn if there exists a superior alternative solution.

@skirtles-code
Copy link
Contributor

I think this may be a duplicate of #8304.

@skirtles-code
Copy link
Contributor

I believe this problem has been fixed as of 3.4.28.

@edison1105
Copy link
Member

Thanks for this PR.
Closing as the problem has been fixed via #8304.

@edison1105 edison1105 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants