Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): ensure invokeArrayFns handles undefined arguments #10869

Merged
merged 2 commits into from
May 20, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented May 6, 2024

Close #10863.

Ensures invokeArrayFns in shared/src/general.ts handles undefined arguments properly.

Copy link

github-actions bot commented May 6, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB (+6 B) 34.5 kB (+3 B) 31.1 kB (+16 B)
vue.global.prod.js 148 kB (+6 B) 53.7 kB (+3 B) 48.1 kB (+43 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB (+6 B) 19.9 kB (+3 B) 18.1 kB (-3 B)
createSSRApp 54.1 kB (+6 B) 21.2 kB (+2 B) 19.3 kB (-4 B)
defineCustomElement 53.1 kB (+6 B) 20.6 kB (+2 B) 18.8 kB (+2 B)
overall 64.5 kB (+6 B) 24.9 kB (+3 B) 22.6 kB (+14 B)

@skirtles-code
Copy link
Contributor

Is it possible to include test cases for this fix?

@jh-leong jh-leong force-pushed the fix/invokeArrayFns branch from 5cd0973 to 92d4caf Compare May 8, 2024 12:17
@jh-leong
Copy link
Member Author

jh-leong commented May 8, 2024

Is it possible to include test cases for this fix?

Yes, I have updated the tests to cover this fix. Thank you for your suggestion!

@haoqunjiang haoqunjiang added ready to merge The PR is ready to be merged. 🔩 p2-edge-case labels May 15, 2024
@jh-leong jh-leong force-pushed the fix/invokeArrayFns branch from 92d4caf to 3a5dd5a Compare May 15, 2024 11:49
@haoqunjiang
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented May 20, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@haoqunjiang haoqunjiang merged commit 9b40d0f into vuejs:main May 20, 2024
11 checks passed
@jh-leong jh-leong deleted the fix/invokeArrayFns branch May 20, 2024 14:17
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 p2-edge-case ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onBeforeXXX 生命周期存在一个默认参数undefined
4 participants