Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): correctly transform non-identifier expressions in legacy filter syntax #10896

Merged
merged 4 commits into from
May 27, 2024

Conversation

haoqunjiang
Copy link
Member

Fixes #10852

Copy link

github-actions bot commented May 9, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB 53.7 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.5 kB 24.9 kB 22.6 kB

@haoqunjiang haoqunjiang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: v2 compat labels May 10, 2024
@haoqunjiang haoqunjiang marked this pull request as ready for review May 11, 2024 02:10
@haoqunjiang haoqunjiang added the ready for review This PR requires more reviews label May 11, 2024
@haoqunjiang
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented May 11, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Note: the Nuxt suite failed with a timeout at first, but it succeeded in the second run, so I edited the table.

@yyx990803 yyx990803 merged commit 07b3c4b into vuejs:main May 27, 2024
11 checks passed
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: v2 compat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters no longer work since 3.4.0-alpha.4 (@vue/compat)
3 participants