Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KeepAlive): properly cache nested Suspense subtree #10912

Merged
merged 4 commits into from
May 24, 2024
Merged

fix(KeepAlive): properly cache nested Suspense subtree #10912

merged 4 commits into from
May 24, 2024
+60 −2

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented May 11, 2024 •
edited
Loading

close #10899

@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.8 kB (+75 B) 34.5 kB (+21 B) 31.1 kB (+26 B)
vue.global.prod.js 148 kB (+75 B) 53.7 kB (+18 B) 48 kB (+43 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.6 kB (+75 B) 24.9 kB (+22 B) 22.6 kB (-3 B)

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented May 11, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ❌ failure ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@edison1105 edison1105 added 🐞 bug Something isn't working scope: keep-alive scope: suspense ready for review This PR requires more reviews labels May 11, 2024
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented May 24, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@haoqunjiang haoqunjiang added ready to merge The PR is ready to be merged. and removed ready for review This PR requires more reviews labels May 24, 2024
@haoqunjiang haoqunjiang merged commit 07764fe into vuejs:main May 24, 2024
10 of 11 checks passed
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@edison1105 @lynxlangya
fix(KeepAlive): properly cache nested Suspense subtree (vuejs#10912)
adf2d0c 
* fix(KeepAlive): properly cache nested Suspense subtree

* test: add test case

* chore: add comments

* Update KeepAlive.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianGlowala DamianGlowala DamianGlowala left review comments

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working ready to merge The PR is ready to be merged. scope: keep-alive scope: suspense
Projects
None yet
Milestone
No milestone
4 participants
@edison1105 @vue-bot @haoqunjiang @DamianGlowala