-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct the type of <details>
's onToggle
event handler
#10938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
haoqunjiang
requested changes
May 14, 2024
haoqunjiang
approved these changes
May 15, 2024
frsimond
reviewed
May 17, 2024
@@ -406,7 +406,7 @@ export interface DataHTMLAttributes extends HTMLAttributes { | |||
|
|||
export interface DetailsHTMLAttributes extends HTMLAttributes { | |||
open?: Booleanish | |||
onToggle?: Event | |||
onToggle?: (payload: ToggleEvent) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used the tooling in place to fix this locally on my project. Dont know if it is good practice or not.
interface DetailsHTMLEvents {
onToggle?: ToggleEvent;
}
export interface DetailsHTMLAttributes extends HTMLAttributes, EventHandlers<DetailsHTMLEvents> {
open?: Booleanish;
}
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
haoqunjiang
changed the title
fix: details tag onToggle type error
fix: correct the type of May 20, 2024
<details>
's onToggle
event handler
lynxlangya
pushed a commit
to lynxlangya/core
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10928