Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patchProp): prevent setting state as attribute for custom elements #11165

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Jun 18, 2024

close #11163

In Vue 3.4.28+, the value prop for custom elements is being set as an attribute and converted to a string, causing issues when value is meant to be an object.

Changes:

  • Added a condition to skip setting form state as an attribute for custom elements.

@LinusBorg LinusBorg added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: custom elements labels Jun 20, 2024
@yyx990803 yyx990803 merged commit 8ae4c29 into vuejs:main Jun 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: custom elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(vue-model): does not pass values when using an object string
3 participants