Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-fix size report #11204

Merged
merged 1 commit into from
Jun 23, 2024
Merged

ci: re-fix size report #11204

merged 1 commit into from
Jun 23, 2024

Conversation

ferferga
Copy link
Contributor

@ferferga ferferga commented Jun 23, 2024

Follow-up of #11203 (see this comment)

  • comment_tag comes last so GH Actions interpreter doesn't trip with special characters from the previous' input
  • The action already encloses the tag with the appropiate hidden markers

Signed-off-by: GitHub <noreply@github.com>
@ferferga ferferga mentioned this pull request Jun 23, 2024
@ferferga ferferga changed the title ci: fix size report again ci: re-fix size report Jun 23, 2024
@sxzz sxzz merged commit 4e8045b into vuejs:main Jun 23, 2024
11 checks passed
@ferferga ferferga deleted the fix-ci-again branch June 23, 2024 19:20
@ferferga
Copy link
Contributor Author

@sxzz I'm astonished by seeing that for some reason this is not working. I'm completely out of ideas right now.

Check this run for this PR

If I recreate the exact same conditions in my fork by merging that branch with the main branch (up to date with current commit) in my fork with this PR, the run works successfully.

@sxzz
Copy link
Member

sxzz commented Jun 23, 2024

Seems like github.event.workflow_run.pull_requests[0].number requires write permission of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants