Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sfc-playground): editor can modify whether auto-save is enabled #11428

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Jul 23, 2024

reference: #11423

Copy link

github-actions bot commented Jul 23, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

@yyx990803
Copy link
Member

This only implements the button but doesn't seem to actually change the editor's behavior?

@phk422
Copy link
Contributor Author

phk422 commented Jul 25, 2024

This only implements the button but doesn't seem to actually change the editor's behavior?

Yes, the current editor does not support dynamic switching of the 'autoSave' property, so I have submitted a PR (vuejs/repl#266) to @vue/repl to add support for it.

Copy link

pkg-pr-new bot commented Sep 8, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11428

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11428

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11428

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11428

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11428

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11428

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11428

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11428

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11428

vue

pnpm add https://pkg.pr.new/vue@11428

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11428

commit: 02851c7

@phk422
Copy link
Contributor Author

phk422 commented Sep 8, 2024

This only implements the button but doesn't seem to actually change the editor's behavior?

Hello, @yyx990803! with the release of @vue/repl@4.4.0, this behavior in the editor is now supported! I believe this PR is ready to be merged. 😃

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: playground labels Sep 9, 2024
@yyx990803 yyx990803 merged commit d0b513e into vuejs:main Sep 10, 2024
13 checks passed
@phk422 phk422 deleted the feature/switch-autoSave branch September 10, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants