-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-dom): prevent unnecessary DOM update from v-model #11656
Merged
yyx990803
merged 10 commits into
vuejs:main
from
Procrustes5:fix(v-model)-prevent-unnecessary-DOM-update-from-v-model
Sep 3, 2024
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4300b3b
fix: introduce newChecked
Procrustes5 947f164
test: check if DOM updated
Procrustes5 c4c88c1
fix: modify checking array and set
Procrustes5 981e8cf
chore: prettier
Procrustes5 756110b
fix: respond to Set input
Procrustes5 baa8d97
chore: return unnecessary changes
Procrustes5 cb075d7
Update vModel.ts
yyx990803 f95072a
Merge branch 'main' into fix(v-model)-prevent-unnecessary-DOM-update-…
Procrustes5 2c92f37
Merge branch 'main' into fix(v-model)-prevent-unnecessary-DOM-update-…
Procrustes5 22d4ee5
Merge branch 'main' into fix(v-model)-prevent-unnecessary-DOM-update-…
Procrustes5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here is not necessary.
We've already cloned the set on line 141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edison1105
Thank you for review!
Obviously, it was unnecessary, I've fixed it!