Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): pass oldValue to computed getter #11813

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #11812

Copy link

github-actions bot commented Sep 4, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+8 B) 37.7 kB (+4 B) 33.9 kB (-2 B)
vue.global.prod.js 159 kB (+8 B) 57.6 kB (+4 B) 51.2 kB (-8 B)

Usages

Name Size Gzip Brotli
createApp 55.2 kB (+8 B) 21.2 kB (+4 B) 19.4 kB (+36 B)
createSSRApp 59.1 kB (+8 B) 22.9 kB (+3 B) 20.9 kB (+34 B)
defineCustomElement 59.9 kB (+8 B) 22.8 kB (+6 B) 20.8 kB (+49 B)
overall 68.9 kB (+8 B) 26.3 kB (+5 B) 23.9 kB (+1 B)

Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11813

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11813

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11813

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11813

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11813

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11813

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11813

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11813

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11813

vue

pnpm add https://pkg.pr.new/vue@11813

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11813

commit: cb9c0a5

@ferferga
Copy link
Contributor

ferferga commented Sep 4, 2024

I can confirm that this fixes the issue! Thank you very much for the quick fix ❤️🚀!

@edison1105 edison1105 changed the title fix(reactivity): pass previous value when trigger getter fix(reactivity): pass oldValue to computed getter Sep 5, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 5, 2024
@yyx990803 yyx990803 merged commit 98864a7 into vuejs:main Sep 5, 2024
13 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/computed branch September 6, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.5.0+] Previous values from computed are always undefined
4 participants