Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typo): added name attribute support to details tag #11823

Merged
merged 5 commits into from
Sep 5, 2024
Merged

fix(typo): added name attribute support to details tag #11823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c5517b
fix(typo): added name attribute support to details tag
Sep 5, 2024
242396c
Merge remote-tracking branch 'upstream/main'
Sep 5, 2024
a91e48e
fix(typo): added test
Sep 5, 2024
0426878
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 5, 2024
34f19b2
Merge branch 'main' into bwsy/fix/11821
baiwusanyu-c Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages-private/dts-test/tsx.test-d.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,5 @@ expectType<JSX.Element>(
xmlns="http://www.w3.org/2000/svg"
/>,
)
// details
expectType<JSX.Element>(<details name="details" />)
1 change: 1 addition & 0 deletions packages/runtime-dom/src/jsx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ export interface DataHTMLAttributes extends HTMLAttributes {
}

export interface DetailsHTMLAttributes extends HTMLAttributes {
name?: string
open?: Booleanish
onToggle?: (payload: ToggleEvent) => void
}
Expand Down