-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): optimize the order of keys in mergeProps #11883
Open
zh-lx
wants to merge
4
commits into
vuejs:main
Choose a base branch
from
zh-lx:fix-merge-props-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/runtime-core
@vue/reactivity
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
zh-lx
changed the title
fix: optimize the order of keys in mergeProps
fix(runtime-core): optimize the order of keys in mergeProps
Sep 10, 2024
edison1105
reviewed
Sep 10, 2024
edison1105
added
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
wait changes
labels
Sep 10, 2024
Co-authored-by: edison <daiwei521@126.com>
edison1105
added
ready to merge
The PR is ready to be merged.
and removed
wait changes
labels
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
ready to merge
The PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11880
The cause of this bug is that during the execution of
mergeProps
,my-info="default 1"
first addsmy-info
toprops
, thenv-bind="{ myInfo: 'default 2', 'my-info': 'Some value' }"
addsmyInfo
toprops
and updates the value ofmy-info
(but does not change the order of the keys). During rendering, the keys inprops
are rendered in the order they were added. SincemyInfo
was added aftermy-info
, the final rendered value is that ofmyInfo
.Therefore, during the execution of
mergeProps
, the order of keys corresponding to later updates should always remain at the end.