Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): migrate global types to packages-private #11904

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Sep 12, 2024

  • Fix type errors in packages-private due to missing global types
  • Clean up unused global types from the main package

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11904

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11904

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11904

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11904

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11904

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11904

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11904

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11904

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11904

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11904

vue

pnpm add https://pkg.pr.new/vue@11904

commit: cb7ad38

@jh-leong jh-leong marked this pull request as draft September 12, 2024 08:17
@jh-leong jh-leong changed the title chore(types): migrate vite/client types to packages-private chore(types): migrate global types to packages-private Sep 12, 2024
@jh-leong jh-leong marked this pull request as ready for review September 12, 2024 08:26
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Sep 12, 2024
@yyx990803 yyx990803 merged commit bc3ddca into vuejs:main Sep 16, 2024
13 checks passed
@jh-leong jh-leong deleted the chore/client_type branch September 16, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants