Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): ensure this.$props type does not include string #12123

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Oct 7, 2024

close #12122

Copy link

github-actions bot commented Oct 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12123

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12123

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12123

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12123

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12123

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12123

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12123

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12123

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12123

vue

pnpm add https://pkg.pr.new/vue@12123

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12123

commit: b10b81e

@jh-leong
Copy link
Member Author

jh-leong commented Oct 7, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 7, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Oct 8, 2024
@yyx990803 yyx990803 merged commit 704173e into vuejs:main Oct 11, 2024
13 checks passed
@jh-leong jh-leong deleted the fix/12122 branch October 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this.$props's type is broken
4 participants