Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-runtime): make AllowedComponentProps & ComponentCustomProps extend IntrinsicAttributes #12385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhiyuanzmj
Copy link
Contributor

closed #12384

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 21 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12385

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12385

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12385

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12385

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12385

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12385

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12385

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12385

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12385

vue

pnpm add https://pkg.pr.new/vue@12385

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12385

commit: f5ef8aa

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSX can't add custom props because of IntrinsicAttributes don't extends any interface.
2 participants