Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-dom): properly stringify template string style #12392

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Nov 14, 2024

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB 18.3 kB 16.7 kB
createApp 55.1 kB 21.3 kB 19.5 kB
createSSRApp 59.1 kB 23 kB 20.9 kB
defineCustomElement 59.9 kB 22.9 kB 20.8 kB
overall 68.8 kB 26.4 kB 23.9 kB

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12392

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12392

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12392

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12392

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12392

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12392

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12392

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12392

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12392

vue

pnpm add https://pkg.pr.new/vue@12392

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12392

commit: 8cb713e

@edison1105 edison1105 changed the title fix(compiler-dom): properly stringify template string bindings fix(compiler-dom): properly stringify template string style Nov 14, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: compiler 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Nov 14, 2024
@yyx990803 yyx990803 merged commit 2d78539 into main Nov 15, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/12391 branch November 15, 2024 02:56
noootwo pushed a commit to noootwo/core that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style binding on SVG shapes breaks at times
2 participants