Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reactivity): remove unnecessary array copy #12400

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

edison1105
Copy link
Member

this change was for #5783 in #12373. it's not necessary since #5783 was fixed via 2193284

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Nov 15, 2024
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.6 kB (-5 B) 37.8 kB (-4 B) 34.1 kB (-62 B)
vue.global.prod.js 157 kB (-5 B) 57.7 kB (-8 B) 51.4 kB (-9 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB (-5 B) 18.3 kB (-8 B) 16.7 kB (-5 B)
createApp 55.1 kB (-5 B) 21.3 kB (-10 B) 19.4 kB (-22 B)
createSSRApp 59.1 kB (-5 B) 23 kB (-9 B) 20.9 kB (-11 B)
defineCustomElement 59.9 kB (-5 B) 22.9 kB (-14 B) 20.8 kB (-7 B)
overall 68.8 kB (-5 B) 26.4 kB (-9 B) 23.9 kB (-3 B)

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12400

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12400

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12400

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12400

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12400

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12400

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12400

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12400

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12400

vue

pnpm add https://pkg.pr.new/vue@12400

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12400

commit: f01054f

@yyx990803 yyx990803 merged commit 70b44ca into main Nov 15, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/chore/effectScope branch November 15, 2024 02:37
noootwo pushed a commit to noootwo/core that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants