Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shouldn't throw error on hydration Teleport mismatch #1271

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented Jun 1, 2020

fix #1235

@underfin
Copy link
Member Author

underfin commented Jun 1, 2020

image
Run single test is ok...

@pikax
Copy link
Member

pikax commented Jun 1, 2020

seems is happening because other tests are adding to the document.body works if you clean the children

  beforeEach(() => {
    while (document.body.hasChildNodes()) {
      document.body.removeChild(document.body.firstChild!)
    }
  })

@underfin
Copy link
Member Author

underfin commented Jun 1, 2020

@pikax thanks a lot!

@yyx990803 yyx990803 merged commit c463a71 into vuejs:master Jun 12, 2020
@underfin underfin deleted the fix-teleport-hydration branch June 12, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport is throwing "TypeError: Cannot read property 'nextSibling' of null" on SSR
3 participants