Skip to content

fix(vapor): handle vapor mode with empty script #12910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Feb 19, 2025

This is because we ignore empty script by default.

related PRs

@edison1105 edison1105 added the scope: vapor related to vapor mode label Feb 19, 2025
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 02d62f8
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67b58b112953f30008a05127
😎 Deploy Preview https://deploy-preview-12910--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edison1105 edison1105 force-pushed the edison/fix/vaporEmptyScript branch from 42e5a80 to 6aebc52 Compare February 19, 2025 03:25
Copy link

pkg-pr-new bot commented Feb 19, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12910

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12910

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12910

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12910

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@12910

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12910

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12910

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12910

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@12910

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12910

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12910

vue

npm i https://pkg.pr.new/vue@12910

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12910

commit: 02d62f8

@edison1105 edison1105 marked this pull request as draft February 19, 2025 03:29
@edison1105 edison1105 marked this pull request as ready for review February 19, 2025 06:13
@yyx990803 yyx990803 merged commit fb484f4 into vapor Feb 28, 2025
13 checks passed
@yyx990803 yyx990803 deleted the edison/fix/vaporEmptyScript branch February 28, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants