Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add RawSlots in h signature #1293

Merged
merged 1 commit into from
Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/runtime-core/__tests__/h.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { h } from '../src/h'
import { createVNode } from '../src/vnode'
import { RawSlots } from '../src/componentSlots'

// Since h is a thin layer on top of createVNode, we are only testing its
// own logic here. Details of vnode creation is tested in vnode.spec.ts.
Expand Down Expand Up @@ -31,8 +32,14 @@ describe('renderer: h', () => {
test('type + props + children', () => {
// array
expect(h('div', {}, ['foo'])).toMatchObject(createVNode('div', {}, ['foo']))
// default slot
// slots
const slots = {} as RawSlots
expect(h('div', {}, slots)).toMatchObject(createVNode('div', {}, slots))
const Component = { template: '<br />' }
expect(h(Component, {}, slots)).toMatchObject(
createVNode(Component, {}, slots)
)
// default slot
const slot = () => {}
expect(h(Component, {}, slot)).toMatchObject(
createVNode(Component, {}, slot)
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/h.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export function h(type: string, children?: RawChildren): VNode
export function h(
type: string,
props?: RawProps | null,
children?: RawChildren
children?: RawChildren | RawSlots
): VNode

// fragment
Expand Down
3 changes: 3 additions & 0 deletions test-dts/h.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ describe('h inference w/ element', () => {
expectError(h('div', { ref: [] }))
expectError(h('div', { ref: {} }))
expectError(h('div', { ref: 123 }))
// slots
const slots = { default: () => {} } // RawSlots
h('div', {}, slots)
})

describe('h inference w/ Fragment', () => {
Expand Down