Skip to content

fix(TransitionGroup): reset prevChildren to prevent memory leak #13183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 10, 2025

close #13181

When the child component is unmounted, the el was retained in prevChildren without being released, causing the memory leak

Copy link

github-actions bot commented Apr 10, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+11 B) 38.2 kB (+9 B) 34.4 kB (+16 B)
vue.global.prod.js 158 kB (+11 B) 58.3 kB (+7 B) 51.9 kB (-3 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.1 kB 16.6 kB
createApp 54.4 kB 21.2 kB 19.4 kB
createSSRApp 58.6 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.7 kB 20.7 kB
overall 68.5 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13183

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13183

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13183

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13183

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13183

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13183

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13183

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13183

vue

npm i https://pkg.pr.new/vue@13183

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13183

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13183

commit: bc24456

@edison1105 edison1105 changed the title fix(TransitionGroup): reset prevChildren in to prevent memory leak fix(TransitionGroup): reset prevChildren to prevent memory leak Apr 10, 2025
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 10, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
quasar success success
nuxt success success
language-tools success success
radix-vue success success
primevue success success
pinia success success
router success success
test-utils success success
vitepress success success
vant success success
vueuse success success
vite-plugin-vue success success
vue-macros success success
vue-i18n success success
vue-simple-compiler success success
vuetify success success

@edison1105 edison1105 added need test The PR has missing test cases. scope: transition ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Apr 10, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed need test The PR has missing test cases. labels Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leaks when using transition-group
2 participants