Skip to content

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented May 26, 2025

Playground with this PR

Copy link

netlify bot commented May 26, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 398c16f
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/683416aca51e300008921f70
😎 Deploy Preview https://deploy-preview-13382--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

coderabbitai bot commented May 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vdomInteropWithProps

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

pkg-pr-new bot commented May 26, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13382

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13382

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13382

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13382

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13382

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13382

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13382

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13382

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13382

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13382

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13382

vue

npm i https://pkg.pr.new/vue@13382

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13382

commit: 0016c11

@edison1105 edison1105 added the scope: vapor related to vapor mode label May 26, 2025
@edison1105 edison1105 force-pushed the edison/fix/vdomInteropWithProps branch from 9477b91 to 398c16f Compare May 26, 2025 07:22
@edison1105 edison1105 changed the title fix(vapor): special handling vapor props in vdom interop fix(runtime-vapor): special handling vapor props in vdom interop May 26, 2025
@edison1105 edison1105 changed the title fix(runtime-vapor): special handling vapor props in vdom interop fix(runtime-vapor): pass plain object props to createVNode during vdom interop May 27, 2025
@@ -151,7 +151,7 @@ function createVDOMComponent(
const frag = new VaporFragment([])
const vnode = createVNode(
component,
rawProps && new Proxy(rawProps, rawPropsProxyHandlers),
rawProps && extend({}, new Proxy(rawProps, rawPropsProxyHandlers)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass a plain object instead of a Proxy one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution is to add a set trap to rawPropsProxyHandlers

Base automatically changed from vapor to minor July 7, 2025 00:06
@edison1105 edison1105 moved this to Vapor in Next Minor Jul 16, 2025
Copy link

github-actions bot commented Sep 1, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB (+6 B) 25.9 kB (+4 B) 23.6 kB (+25 B)
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 79a76da
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b54834501b7d000776c8d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode wait changes
Projects
Status: Vapor
Development

Successfully merging this pull request may close these issues.

1 participant