-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
fix(runtime-vapor): pass plain object props to createVNode during vdom interop #13382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
9477b91
to
398c16f
Compare
@@ -151,7 +151,7 @@ function createVDOMComponent( | |||
const frag = new VaporFragment([]) | |||
const vnode = createVNode( | |||
component, | |||
rawProps && new Proxy(rawProps, rawPropsProxyHandlers), | |||
rawProps && extend({}, new Proxy(rawProps, rawPropsProxyHandlers)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass a plain object instead of a Proxy one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution is to add a set
trap to rawPropsProxyHandlers
Size ReportBundles
Usages
|
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
TypeError: Cannot redefine property: class
occurredPlayground with this PR