Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): should ignore inline data url #1431

Merged
merged 6 commits into from
Jun 24, 2020
Merged

fix(compiler-sfc): should ignore inline data url #1431

merged 6 commits into from
Jun 24, 2020

Conversation

underfin
Copy link
Member

@sibbng
Copy link

sibbng commented Jun 23, 2020

Is this PR covers this code too?

<img src='data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="100" width="100"><circle cx="50" cy="50" r="40" stroke="black" stroke-width="3" fill="red" /></svg>'>

I'm getting same error on this too and it is not contains any base64. Maybe we should call it isDataUrl()?

@underfin
Copy link
Member Author

Yeah.It should inculde into this.I will update code.

@underfin underfin changed the title fix(compiler-sfc): should ignore inline base64 url fix(compiler-sfc): should ignore inline data url Jun 23, 2020
@yyx990803 yyx990803 mentioned this pull request Jun 23, 2020
Closed
@yyx990803 yyx990803 merged commit 90c285c into vuejs:master Jun 24, 2020
@underfin underfin deleted the sfc-ignore-base64url branch June 24, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underfin @sibbng @yyx990803