Skip to content

Conversation

@tarnishablec
Copy link

#1489)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related?

Copy link
Author

@tarnishablec tarnishablec Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to prevent deno plugin in vscode keep prompting error for no .ts extension in import urls
https://github.com/denoland/vscode_deno

@dsonet
Copy link
Contributor

dsonet commented Jul 2, 2020

It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct.
Just like concept vs the real world.
IMO the best way to deal with it is to put this into limitations section.

@aztalbot
Copy link
Contributor

aztalbot commented Jul 2, 2020

A solution with little to no performance impact for this specific case would be a public function to add constructors to the collectionTypes Set (ex. addCollectionType). @tarnishablec Do you think that would work for your use case? The current solution here slows reactive object creation for all use cases. Extending these collection types is not common, so I don't think it would be surprising to have to tell Vue about your new class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants