Skip to content

fix(reactivity): observe instance from subclass of Collection (close … #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tarnishablec
Copy link

#1489)

@@ -13,5 +13,6 @@
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
},
"deno.enable": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related?

Copy link
Author

@tarnishablec tarnishablec Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to prevent deno plugin in vscode keep prompting error for no .ts extension in import urls
https://github.com/denoland/vscode_deno

@dsonet
Copy link
Contributor

dsonet commented Jul 2, 2020

It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct.
Just like concept vs the real world.
IMO the best way to deal with it is to put this into limitations section.

@aztalbot
Copy link
Contributor

aztalbot commented Jul 2, 2020

A solution with little to no performance impact for this specific case would be a public function to add constructors to the collectionTypes Set (ex. addCollectionType). @tarnishablec Do you think that would work for your use case? The current solution here slows reactive object creation for all use cases. Extending these collection types is not common, so I don't think it would be surprising to have to tell Vue about your new class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants