New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): remove attribute when value is falsy. #1582

Closed

zhangzhonghe wants to merge 2 commits into vuejs:master from zhangzhonghe:patch-2

Member

zhangzhonghe commented Jul 14, 2020

zhangzhonghe added 2 commits

July 14, 2020 20:10


          fix(runtime-dom): remove attribute when value is falsy.

caed556

see #1576


          test(runtime-dom): add test.

Member

yyx990803 commented Jul 14, 2020

According to this RFC in 3.0 v-bind:foo="false" will render as foo="false" instead of removing the attribute
This code path may have to deal with DOM properties that do not have corresponding attributes, so only removing the attribute will not cover all possible cases.

yyx990803 closed this

zhangzhonghe deleted the patch-2 branch

July 15, 2020 01:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet