Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): add FULL_PROPS patch flags when cloned vnode has… #1666

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): add FULL_PROPS patch flags when cloned vnode has… #1666

wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jul 21, 2020 •
edited
Loading

… NEED_PATCH patch flags

fix #1665

Bug Reson

The patch flags of div.container is changed by cloneVnode(NEED_PATCH -> BAIL). Caused the children diff and mount the children twice.

@yyx990803
Copy link
Member

I realized we should avoid using bail flags since it affects how children are handled. See 6390ddf

@yyx990803 yyx990803 closed this Jul 21, 2020
@underfin underfin deleted the fix-clone-vnode branch July 22, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-for render twice
2 participants
@underfin @yyx990803