Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): normalize empty extra props to null for cloneVnode #1724

Closed
wants to merge 1 commit into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jul 28, 2020

fix #1704

This pr fix empty extra props, this will change patchFlag(this can fix the issue).
But the real reason with this issue is here.
https://github.com/vuejs/vue-next/blob/5c74243211495e33319218584993177c9d2e2c80/packages/runtime-core/src/componentRenderUtils.ts#L250-L252
The pushed vnode will cause error when patch this(there are block node and previous block tree maybe hasn't this node)

@yyx990803
Copy link
Member

The root cause of #1704 is because v-if in off state renders a comment node, which is then mistakenly filtered out as a user comment when trying to determine fallthrough target in a fragment root with user comments. See 355c052

This fix should be unnecessary since in compiled output cloneVNode should only happen for real root nodes which are always blocks themselves.

@sheldonstewart
Copy link

so what is the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled error during execution of scheduler flush.
3 participants