Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): set ref in the post-render queue #1835

Merged
merged 4 commits into from
Aug 13, 2020
Merged

fix(runtime-core): set ref in the post-render queue #1835

merged 4 commits into from
Aug 13, 2020

Conversation

HcySunYang
Copy link
Member

@HcySunYang HcySunYang commented Aug 12, 2020 •
edited by posva
Loading

Fix #1834
Fix #1789 .

Unresolved question: when ref is a function, keep the current behavior?

@zhangzhonghe
Copy link
Member

After my test, this did not fix #1789.

@HcySunYang
Copy link
Member Author

Sure, and I updated this PR, now everything works correctly, the solution is:

    1. unset ref synchronously (within the rendering cycle)
    1. set ref in the "after rendering" queue

....CI failure does not seem to be related to this PR.

@yyx990803 yyx990803 merged commit 3991ff0 into vuejs:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swapping ref attributes leads to a null in $refs Moving an element drops the ref
3 participants
@HcySunYang @zhangzhonghe @yyx990803