Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): don't inherit el if child is block node #1905

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): don't inherit el if child is block node #1905

wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

fix #1903

@yyx990803
Copy link
Member

We can simply check if the new vnode already has el (since dynamic children are already patched). It would be more efficient than a includes check on every child. See d4cc7b2

@yyx990803 yyx990803 closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-if inside of <teleport> fails when having multiple <teleport> children
3 participants
@underfin @yyx990803 @edison1105