Skip to content

Conversation

@HcySunYang
Copy link
Member

Fix: #1975

@yyx990803
Copy link
Member

When reviewing this I realized two things:

  1. props/emits options need to be resolved per instance/component combo due to global mixins
  2. the resolved options must be cached on the component using app instance uid as key, since the same component may get used in different apps with different global mixins!
  3. We can avoid all these normalizePropsOptions calls by storing the resolved options directly on the instance.

So that leads to some pretty substantial refactoring - see 8ed0b34 (which includes the test from this PR)

@yyx990803 yyx990803 closed this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prop not present when added by a global mixin

2 participants