New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): respect props from global mixins #1982

Closed

HcySunYang wants to merge 1 commit into vuejs:master from HcySunYang:fix-props-from-global-mixins

Member

HcySunYang commented Aug 27, 2020

Fix: #1975


          fix(runtime-core): respect props from global mixins

8413b0d

Member

yyx990803 commented Aug 31, 2020

When reviewing this I realized two things:

props/emits options need to be resolved per instance/component combo due to global mixins
the resolved options must be cached on the component using app instance uid as key, since the same component may get used in different apps with different global mixins!
We can avoid all these normalizePropsOptions calls by storing the resolved options directly on the instance.

So that leads to some pretty substantial refactoring - see 8ed0b34 (which includes the test from this PR)

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet