Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove required arguments of app.unmount() (close: #2922) #2924

Closed
wants to merge 2 commits into from
Closed

fix: remove required arguments of app.unmount() (close: #2922) #2924

wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jan 1, 2021

close #2922

@skirtles-code
Copy link
Contributor

Is this the same as #2601?

@LinusBorg LinusBorg mentioned this pull request Jan 1, 2021
Closed
@LinusBorg LinusBorg changed the title fix: remove required arguments of app.unmount() fix: remove required arguments of app.unmount() (close: #2922) Jan 1, 2021
@LinusBorg LinusBorg added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types labels Jan 1, 2021
@posva
Copy link
Member

posva commented Jan 4, 2021

Closing in favor of the older #2601

@posva posva closed this Jan 4, 2021
@underfin underfin deleted the unmout-define-type branch January 6, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy between code and documentation (also header) of app.unmount
4 participants
@underfin @skirtles-code @posva @LinusBorg