Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): refactor current rendering instance to stack for SSR #3461

Closed
wants to merge 2 commits into from
Closed

fix(ssr): refactor current rendering instance to stack for SSR #3461

wants to merge 2 commits into from

Conversation

HcySunYang
Copy link
Member

Fix: #2863

@HcySunYang HcySunYang added the need test The PR has missing test cases. label Mar 23, 2021
@HcySunYang HcySunYang removed the need test The PR has missing test cases. label Mar 23, 2021
@yyx990803
Copy link
Member

It's cheaper to not have to maintain a stack by storing the prev instance before setting a new instance (like we are already doing in withCtx). See 8c3c14a

@yyx990803 yyx990803 closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug with vue3 ssr and dynamic component
3 participants
@HcySunYang @yyx990803 @posva