Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warn): skip ShadowRoot check on unsupported platforms #4238

Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix(warn): skip ShadowRoot check on unsupported platforms #4238

merged 1 commit into from
Aug 2, 2021

Conversation

Hfutsora
Copy link
Contributor

@Hfutsora Hfutsora commented Aug 2, 2021

When using browsers not support the shadowRoot interface, this would throw invalid 'instanceof' operand type error because the window.shadowRoot got undefined.

So i add a defensive code here.

@Hfutsora Hfutsora changed the title fix using instanceof on an undefined property, fix using instanceof on an undefined property Aug 2, 2021
@posva posva changed the title fix using instanceof on an undefined property fix(warn): skip ShadowRoot check on unsupported platforms Aug 2, 2021
@yyx990803 yyx990803 merged commit bc7dd93 into vuejs:master Aug 2, 2021
@Hfutsora Hfutsora deleted the fix-shadowRoot branch June 1, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants