Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RefSugar): support accessing ref binding with TypeScript #4257

Closed
wants to merge 2 commits into from
Closed

fix(RefSugar): support accessing ref binding with TypeScript #4257

wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

close #4254

posva
posva reviewed Aug 5, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems to only handle the ! operator but not casting a as number/<number>a

@edison1105
Copy link
Member Author

Thanks! This seems to only handle the ! operator but not casting a as number/<number>a

oh~ Thanks for your reminder.

@edison1105 edison1105 marked this pull request as draft August 5, 2021 07:13
@edison1105 edison1105 marked this pull request as ready for review August 5, 2021 11:07
@edison1105 edison1105 requested a review from posva August 5, 2021 11:19
@yyx990803
Copy link
Member

Sorry I didn't see this one when working on 865b84b - this PR does cover a case I missed so I included the test case from this PR in 1994f12.

Note the compiler doesn't need to strip the TS syntax as that is the job of dedicated TS transpilers.

@yyx990803 yyx990803 closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva Awaiting requested review from posva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ref sugar (take 2) is not applied when casting in TypeScript
3 participants
@edison1105 @yyx990803 @posva