Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(runtime-core): improve forceUpdate type #4302

Merged
merged 3 commits into from
Aug 11, 2021
Merged

types(runtime-core): improve forceUpdate type #4302

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74708c4
types(runtime-core): improve forceUpdate type
edison1105 Aug 11, 2021
c882a03
chore: clean
edison1105 Aug 11, 2021
0808beb
Update componentPublicInstance.ts
yyx990803 Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/runtime-core/src/componentPublicInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
isFunction
} from '@vue/shared'
import {
ReactiveEffect,
toRaw,
shallowReadonly,
track,
Expand Down Expand Up @@ -192,7 +191,7 @@ export type ComponentPublicInstance<
$emit: EmitFn<E>
$el: any
$options: Options & MergedComponentOptionsOverride
$forceUpdate: ReactiveEffect
$forceUpdate: () => void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the public type and it doesn't take any arguments / return anything

$nextTick: typeof nextTick
$watch(
source: string | Function,
Expand Down