Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support undefined type validate in prop #5940

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support undefined type validate in prop #5940

wants to merge 2 commits into from

Conversation

liulinboyi
Copy link
Member

close #5471
feat: support undefined type validate in prop.

@liulinboyi
Copy link
Member Author

liulinboyi commented May 17, 2022 •
edited
Loading

Preview

@liulinboyi
Copy link
Member Author

Already tick the "allow edits from maintainer".

@yyx990803
Copy link
Member

Can you please add a test case for this in componentProps.spec.ts?

@liulinboyi
Copy link
Member Author

liulinboyi commented May 18, 2022 via email

@netlify
Copy link

netlify bot commented May 18, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 96f08547b8389eed21323c8405b3b0a2313fb085
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6284d37c952c68000888c737

@liulinboyi
Copy link
Member Author

Can you please add a test case for this in componentProps.spec.ts?

Test has been added, All done👌.

@SimmeNilsson
Copy link

Was looking for something like this. Any idea when we could expect to see it, @yyx990803 ?

@pleek91 pleek91 mentioned this pull request Aug 26, 2022
Closed
@yusufkandemir
Copy link

I believe defineProps<{ foo: number | undefined }> needs to be tested as well(in compileScript.spec.ts) as the target issue(#5471) is mainly about it.

@sharifzadesina
Copy link

Can we have this merged?

@pikax pikax assigned pikax and unassigned pikax Oct 20, 2023
@edison1105 edison1105 added scope: compiler scope: sfc 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews and removed scope: compiler labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews scope: sfc
Projects
Issue / PR Management
Status: Stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined type in prop could warn
7 participants
@liulinboyi @yyx990803 @SimmeNilsson @yusufkandemir @sharifzadesina @edison1105 @pikax