Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-renderer): fix the bug that multi slot scope id does not work on component #6100

Merged
merged 3 commits into from
May 30, 2024

Conversation

mmis1000
Copy link
Contributor

Fix #6093

Split slot scope id before use it as attribute name so it don't break rendering.
Add a test for this bug.

…ork on component

Split slot scope id before use it as attribute name so it don't break rendering.
Add a test for this bug.
@mmis1000 mmis1000 force-pushed the fix/server-rednerer-slot-scope-id branch from fbea64f to 6cb9270 Compare June 12, 2022 10:59
@mmis1000
Copy link
Contributor Author

mmis1000 commented Apr 8, 2023

It's almost one year after I opened this pull request. It shouldn't really take that long for a pull request that comes with a proper reproduction and test. And let alone it is just a 4 line change patch. 🫤

@haoqunjiang haoqunjiang added scope: slots scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels May 29, 2024
@yyx990803 yyx990803 merged commit 4c74302 into vuejs:main May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: slots scope: ssr
Projects
Development

Successfully merging this pull request may close these issues.

:slotted() style does not work in SSR when multi component slotted the same compoennt
3 participants