Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): fire callback when original value is undefined #688

Closed
wants to merge 1 commit into from

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Feb 3, 2020

Fixes #683. Created a symbol for default value, so it's unique and will cause callback run even if original value is undefined. If it's bad solution, I've got another fix idea so PR can be updated.

@dsseng
Copy link
Contributor Author

dsseng commented Feb 3, 2020

Probably this is a duplicate of #687.

@posva
Copy link
Member

posva commented Feb 3, 2020

Let's keep #687 and discuss differences (using a Symbol) there since it was opened before.

@posva posva closed this Feb 3, 2020
@dsseng
Copy link
Contributor Author

dsseng commented Feb 3, 2020

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watch handler not executed immediately if source returns undefined
2 participants