Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): should not set css vars when instance.subtree is null #7016

Closed
wants to merge 1 commit into from
Closed

fix(runtime-dom): should not set css vars when instance.subtree is null #7016

wants to merge 1 commit into from

Conversation

webfansplz
Copy link
Member

Closes #7015

@webfansplz webfansplz marked this pull request as draft November 3, 2022 09:02
@webfansplz webfansplz marked this pull request as ready for review November 3, 2022 10:13
@posva
Copy link
Member

posva commented Nov 3, 2022

Thanks but see #7015 (comment)

If instance could be undefined, the types should be adapted so I don't think this is fixing an expected scenario

@posva posva closed this Nov 3, 2022
@webfansplz webfansplz deleted the fix-css-var branch November 3, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useCssVars throw error when instance.subTree is null
2 participants
@webfansplz @posva