-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler/runtime-dom): firefox do not support regexp flag s
#7268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to use \s\S
instead of (.|\n)
since some cases have already used it.
const forAliasRE = /([\s\S]*?)\s+(?:in|of)\s+([\s\S]*)/ |
Thanks |
Safari on iOS < 12 also impacted |
May I ask when this PR will be merged? This compatibility issue may have a significant impact on the business. |
I have the same issue, plz merge this PR! |
UP for merge! Please pay attention to this PR |
For whom may concern, the issue patched in v3.3.4 |
I confirm, issue is fixed in v3.3.4. Tested on Safari on iOS < 12 and firefox < 72 |
@stondbringa @TNGD-YQ |
Can this change be merged into version 3.2.x. The current version and accompanying tools (such as vite) no longer support Windows 7 (Node <13). Not very friendly to developers who cannot upgrade their systems (such as work computers). |
Fix #7267
Related to #6808 #3917
Playground