Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): add name attribute of Teleport #7315

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix(runtime-core): add name attribute of Teleport #7315

merged 2 commits into from
Nov 9, 2023

Conversation

WalkAlone0325
Copy link
Contributor

All other built-in components have a name attribute.

@WalkAlone0325
fix(runtime-core): add name attribute of Teleport
21b189c 
All other built-in components have a name attribute.
PraveenNanda124
PraveenNanda124 reviewed Dec 26, 2022
View reviewed changes
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pikax pikax added the ready to merge The PR is ready to be merged. label Oct 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB (+16 B) 32.9 kB (+3 B) 29.7 kB (-31 B)
vue.global.prod.js 132 kB (+16 B) 49.6 kB (+1 B) 44.5 kB (+35 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@yyx990803 yyx990803 merged commit 6e0b068 into vuejs:main Nov 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenNanda124 PraveenNanda124 PraveenNanda124 left review comments

@YasinAshorian YasinAshorian YasinAshorian approved these changes

@sxzz sxzz sxzz approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WalkAlone0325 @haoqunjiang @sxzz @YasinAshorian @PraveenNanda124 @yyx990803 @pikax